Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ephemeral resources: kubernetes_token_request_v1, kubernetes_certificate_signing_request_v1 #2628

Merged
merged 13 commits into from
Nov 25, 2024
Merged

Add ephemeral resources: kubernetes_token_request_v1, kubernetes_certificate_signing_request_v1 #2628

merged 13 commits into from
Nov 25, 2024

Conversation

jrhouston
Copy link
Collaborator

Description

This PR adds support for ephemeral resources, introducing ports of the kubernetes_token_request_v1 and kubernetes_certificate_signing_request_v1 resources to ephemeral resources.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

2024/11/20 21:59:44 [DEBUG] Using kubeconfig: /Users/john/.kube/config
=== RUN   TestAccEpehemeralTokenRequest_basic
=== PAUSE TestAccEpehemeralTokenRequest_basic
=== CONT  TestAccEpehemeralTokenRequest_basic
--- PASS: TestAccEpehemeralTokenRequest_basic (3.77s)
PASS
ok  	github.com/hashicorp/terraform-provider-kubernetes/internal/framework/provider/authenticationv1	4.992s
2024/11/20 21:59:45 [DEBUG] Using kubeconfig: /Users/john/.kube/config
=== RUN   TestAccEpehemeralCertificateSigningRequest_basic
=== PAUSE TestAccEpehemeralCertificateSigningRequest_basic
=== CONT  TestAccEpehemeralCertificateSigningRequest_basic
--- PASS: TestAccEpehemeralCertificateSigningRequest_basic (12.85s)
PASS
ok  	github.com/hashicorp/terraform-provider-kubernetes/internal/framework/provider/certificatesv1	15.279s

Release Note

Release note for CHANGELOG:

...

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@jrhouston jrhouston requested a review from a team as a code owner November 21, 2024 03:00
appilon
appilon previously approved these changes Nov 21, 2024
View reviewed changes
@jrhouston jrhouston merged commit b0a4fb9 into main Nov 25, 2024
17 of 25 checks passed
@jrhouston jrhouston deleted the ephemeral-resources-dev branch November 25, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BBBmau BBBmau BBBmau approved these changes

@appilon appilon appilon left review comments

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrhouston @appilon @BBBmau